feat: Team Broker #484
feat: Team Broker #484
Conversation
| @@ -0,0 +1,240 @@ | |||
| {{- if and ( eq .Values.forge.broker.enabled true) ( eq .Values.forge.broker.teamBroker.enabled true ) -}} | |||
| apiVersion: apps.emqx.io/v2beta1 | |||
There was a problem hiding this comment.
With Capabilities we should check if this API exists.
There was a problem hiding this comment.
Something like
{{ if .Capabilities.APIVersions.Has('apps.emqx.io/v2beta1') }}
There was a problem hiding this comment.
Will need to add --api-versions=apps.emqx.io/v2beta1 to the template tests
helm/flowforge/templates/emqx.yaml
Outdated
| } | ||
| } | ||
| dashboard { | ||
| default_password = topSecret |
There was a problem hiding this comment.
Can this be linked to the value from a Secret?
There was a problem hiding this comment.
I don't think so as it's a direct embed into the config file, the idea is that you should change it on first login.
The defaults are to not expose the dashboard that uses this password externally, but it could be accessed internally to the cluster (e.g. I am currently doing kubectl port forwarding)
There was a problem hiding this comment.
FYI It seems like it is possible to do it via environmental variables EMQX_DASHBOARD__DEFAULT_PASSWORD for the password and EMQX_DASHBOARD__DEFAULT_USERNAME
There was a problem hiding this comment.
OK, will need to test if we can inject individual env vars and not wipe out the ones already set on the pods.
There was a problem hiding this comment.
Changes, made, but will need to test
|
Can we take the introduction of a new broker as an opportunity and move broker definitions away from |
I'll have a look |
Co-authored-by: PPawlowski <ppawlowski@users.noreply.github.com>
|
I think I also need to add an existing secret option for the emqx stuff |
|
Marking this as ready for review so we can get it merged tomorrow and use it for the dedicated env. There may be somethings we need to fix for testing (e.g. the apis thing) or things we put off to a follow up PR |
|
@ppawlowski OK, this should be good, the only bit outstanding is the question about having to add |
part of FlowFuse/flowfuse#1350
Description
Add the teamBroker config.
Related Issue(s)
FlowFuse/flowfuse#1350
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel