Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node config action to append if it's not defined #1408

Conversation

gayanSandamal
Copy link
Contributor

Description

@joepavitt I did couple of testings on my local instance but I couldn't recreate it

Screen.Recording.2024-10-16.at.10.36.33.mov

But when I did the same on the dashboard demos instance I could recreate the scenario https://dashboard-demos-dev.flowfuse.cloud/dashboard/table-1

Assuming the root cause is with setting the default in ui_table.js I'm creating this PR and keeping as draft until I get this confirmed with @joepavitt

Related Issue(s)

#1407

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gayanSandamal gayanSandamal linked an issue Oct 16, 2024 that may be closed by this pull request
@gayanSandamal gayanSandamal marked this pull request as draft October 16, 2024 05:38
@gayanSandamal gayanSandamal self-assigned this Oct 21, 2024
@gayanSandamal gayanSandamal marked this pull request as ready for review October 21, 2024 03:32
@gayanSandamal gayanSandamal marked this pull request as draft October 21, 2024 03:41
@joepavitt joepavitt marked this pull request as ready for review October 21, 2024 09:38
@joepavitt
Copy link
Collaborator

Code changes looked fine, but all table-based tests are failing

@gayanSandamal
Copy link
Contributor Author

Code changes looked fine, but all table-based tests are failing

This has happened due to default action method "append". This is fixed with 63bea01

Ready for review

@joepavitt joepavitt merged commit 9617edc into main Oct 22, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 1407-ui-table---data-is-always-replaced-even-if-action-is-append branch October 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui-table - Data is Always Replaced, Even if "Action" is "Append"
2 participants