Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gauge thermometer PR fixes #1421

Open
wants to merge 2 commits into
base: 1203-gauge-type-thermometer
Choose a base branch
from

Conversation

gayanSandamal
Copy link
Contributor

@gayanSandamal gayanSandamal commented Oct 23, 2024

Description

image

Screen.Recording.2024-10-23.at.18.14.38.mov

Related Issue(s)

#1203

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@gayanSandamal
Copy link
Contributor Author

#1410 (comment)

It looks a little too cartoon-like at the moment. To be consistent with the other widget-types, we should not have a gradient in the fill, the border should be the same color as the fill, and there should be a gap between the border and fill. I would also like to see the remova of the border radius at the top of the fill so it reads as a gauge easier.

@joepavitt this PR contains the required fixes. Unfortunately this doesn't allow me to add anyone as reviewers at the moment.

Screenshot 2024-10-23 at 18 18 33

@joepavitt
Copy link
Collaborator

Thanks @gayanSandamal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants