Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Add "image" row type #1422

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

bartbutenaers
Copy link
Contributor

Description

This PR supports a new 'Image' type in tables:

image

Also data urls for base64 encoded images are supported, like the Kohinoor Samudra images in the following flow (see example_flow.txt):

image

Which results in the following table:

image

Note that the last image is truncated. Don't know how to fix that unfortunately...

Related Issue(s)

1418

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt self-requested a review October 29, 2024 10:50
Copy link
Collaborator

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always @bartbutenaers

@joepavitt joepavitt merged commit 5c575f0 into FlowFuse:main Oct 29, 2024
1 of 2 checks passed
@joepavitt joepavitt changed the title images in ui-table Table: Add "image" row type Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants