Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart - Clear stale data from front-end chart #1460

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

joepavitt
Copy link
Collaborator

Description

  • Ensure we consider the cutoff and points in the front-end Chart filtering of stale data.
  • Also extracted out the clearOldPoints function in the server-side to improve readibility/discoverability.

Related Issue(s)

Closes #755

@Steve-Mcl
Copy link
Contributor

Approved in principle but the e2e error looks related?

1) Node/-RED Dashboard 2.0 - Chart Widget
       renders charts with correct data:
     AssertionError: expected Array [] to have property length of 24 (got 0)

Will re-run tests in case of transient issue

@joepavitt
Copy link
Collaborator Author

Yeha, that E2E isn't looking healthy, I'll take a look when I have a chance

@joepavitt
Copy link
Collaborator Author

Test should now be fixed - rerunning in CI to be sure

@joepavitt joepavitt merged commit a4fd7c5 into main Nov 29, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 755-chart-stale-data branch November 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale data not being weeded from chart
2 participants