Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers: support optimized option #81

Closed
paodb opened this issue Jan 9, 2023 · 4 comments · Fixed by #100
Closed

Markers: support optimized option #81

paodb opened this issue Jan 9, 2023 · 4 comments · Fixed by #100
Assignees

Comments

@paodb
Copy link
Member

paodb commented Jan 9, 2023

It was decided on #43 (comment) to remove the option as it doesn't exists in the web component part and it does nothing when enabled.

@javier-godoy
Copy link
Member

Even when this method does nothing, it's part of the public API. It should be deprecated with a comment mentioning that the method serves no purpose.

@paodb
Copy link
Member Author

paodb commented Jan 9, 2023

Maybe we need to re-think this. The idea of removing (now deprecating) the optimized option was because the web component side doesn't have that property, there for, does nothing if the property is set on the server side addon; but it could be added to the web component, as explained here. Would that be a better approach?

@paodb
Copy link
Member Author

paodb commented Jan 17, 2023

As discussed in 2023-01-16 daily, the optimized property should be added to the web-component part. Then server side addon should be updated to use that new property.

@paodb paodb changed the title Markers: remove optimized option Markers: support optimized option Mar 14, 2023
@paodb
Copy link
Member Author

paodb commented Mar 14, 2023

Back to To Do as no update was done yet on related web-component ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants