Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapId & controlSize properties #61

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Add mapId & controlSize properties #61

merged 3 commits into from
Jan 28, 2022
+117 −4

Conversation

paodb
Copy link
Member

@paodb paodb commented Jan 11, 2022 •
edited
Loading

Close #58 & Close #63

@paodb paodb marked this pull request as draft January 11, 2022 20:33
@paodb
Copy link
Member Author

paodb commented Jan 11, 2022 •
edited
Loading

This PR is in draft as it depends on web-component release. (See FlowingCode/google-map#16 & FlowingCode/google-map#18.) Once the release is ready I will update the PR with the new version.

@paodb paodb changed the title feat: add mapId property for map styling Add mapId & controlSize properties Jan 20, 2022
@paodb paodb requested a review from javier-godoy January 20, 2022 19:39
@paodb paodb marked this pull request as ready for review January 27, 2022 20:30
@paodb paodb requested a review from mlopezFC January 27, 2022 20:30
mlopezFC
mlopezFC approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlopezFC mlopezFC merged commit c1f278d into master Jan 28, 2022
@mlopezFC mlopezFC deleted the map-id branch January 28, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlopezFC mlopezFC

@javier-godoy javier-godoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add controlSize feature Please add support for mapId
2 participants
@paodb @mlopezFC