Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error fixed (TS) #1136

Conversation

siddiqss
Copy link
Contributor

@siddiqss siddiqss commented Oct 26, 2023

Error: "Property 'INDEX_NOT_EXIST' does not exist on type 'typeof ErrorCode'. Did you mean 'IndexNotExist'?ts(2551)
error.d.ts(39, 5): 'IndexNotExist' is declared here."
in "packages/components/nodes/vectorstores/Milvus/Milvus_Upsert.ts".

Fixed: Replaced INDEX_NOT_EXIST with IndexNotExist

issue described here: #1135

@siddiqss siddiqss changed the title Build error fixed: issue#1135 Build error fixed (TS) Oct 26, 2023
@automaton82
Copy link
Contributor

Yea I've got the same build error, this change appears to fix it.

@HenryHengZJ
Copy link
Contributor

Its showing error on my side:
image

@automaton82
Copy link
Contributor

@HenryHengZJ I think your packages may be out of date or something else is going wrong. Even with this fixed the build is broken and I'm not sure why. I suspect dependency issue.

@automaton82
Copy link
Contributor

Also if you look at the Milvus SDK source it has changed:

https://github.com/milvus-io/milvus-sdk-node/blob/main/milvus/const/error.ts

Yours shouldn't build with that const value.

@siddiqss
Copy link
Contributor Author

siddiqss commented Oct 27, 2023

@automaton82 What error do you get? My build was successful after this fix.

@automaton82
Copy link
Contributor

@siddiqss #1139 this one

@siddiqss
Copy link
Contributor Author

@automaton82 did you install all dependencies with yarn?

@automaton82
Copy link
Contributor

@siddiqss yes, fresh clone and followed dev steps including yarn install.

I've had this working for weeks, it's only yesterday fresh installs started failing. I tried Windows, Ubuntu 22 and the Docker build. I will try again this morning, maybe a package was broken last night and not today.

@siddiqss
Copy link
Contributor Author

so maybe in the last pull requests someone installed a new package which conflicted with existing one.

@automaton82
Copy link
Contributor

automaton82 commented Oct 27, 2023

I don't think so because I reset the head back to the last public release (18937de), cleaned, deleted node_modules from all folders and re-installed and the same error occurred. I think a dependency has a problem, because I know I built that version 2 weeks ago without issue.

@automaton82
Copy link
Contributor

@HenryHengZJ the automated tests are now failing with this same TS error: https://github.com/FlowiseAI/Flowise/actions/runs/6667186174/job/18120163971

@automaton82
Copy link
Contributor

I closed my #1139 issue as it's no longer happening this morning. But this TS issue remains, and this pull request does fix it, so hopefully it can be merged.

@Initonedeb
Copy link

Hey [automaton82] I guess you were doing the change on Flowise\node_modules\flowise-components\dist\nodes\vectorstores\Milvus instead of packages/components/nodes/vectorstores/Milvus/Milvus_Upsert.ts?

@Initonedeb
Copy link

Allow me to elaborate how i made it work, i had the same issue you have [automaton82], 1) rename flowise folder to anything, 2) git clone repository, 3) cd to flowise, 4) go to packages/components/nodes/vectorstores/Milvus/Milvus_Upsert.ts? Replaced INDEX_NOT_EXIST with IndexNotExist on line 255, 5)Yarn Install 6)Yarn Build. Thats it now it will work.

@automaton82
Copy link
Contributor

@Initonedeb Yes, I fixed the issue this PR fixes manually. But I had a separate build error which is now gone.

@HenryHengZJ
Copy link
Contributor

ah okay, perfect, a fresh new install can see the error:
image

@HenryHengZJ
Copy link
Contributor

thanks everyone!

@HenryHengZJ HenryHengZJ merged commit 936ed9f into FlowiseAI:main Oct 27, 2023
2 checks passed
@automaton82
Copy link
Contributor

Thanks!

@siddiqss siddiqss deleted the bugfix/build-error-index-not-exist-issue-1135 branch October 27, 2023 18:57
hemati pushed a commit to hemati/Flowise that referenced this pull request Dec 27, 2023
…dex-not-exist-issue-1135

Build error fixed (TS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants