-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error fixed (TS) #1136
Build error fixed (TS) #1136
Conversation
Yea I've got the same build error, this change appears to fix it. |
@HenryHengZJ I think your packages may be out of date or something else is going wrong. Even with this fixed the build is broken and I'm not sure why. I suspect dependency issue. |
Also if you look at the Milvus SDK source it has changed: https://github.com/milvus-io/milvus-sdk-node/blob/main/milvus/const/error.ts Yours shouldn't build with that const value. |
@automaton82 What error do you get? My build was successful after this fix. |
@automaton82 did you install all dependencies with yarn? |
@siddiqss yes, fresh clone and followed dev steps including I've had this working for weeks, it's only yesterday fresh installs started failing. I tried Windows, Ubuntu 22 and the Docker build. I will try again this morning, maybe a package was broken last night and not today. |
so maybe in the last pull requests someone installed a new package which conflicted with existing one. |
I don't think so because I reset the head back to the last public release (18937de), cleaned, deleted |
@HenryHengZJ the automated tests are now failing with this same TS error: https://github.com/FlowiseAI/Flowise/actions/runs/6667186174/job/18120163971 |
I closed my #1139 issue as it's no longer happening this morning. But this TS issue remains, and this pull request does fix it, so hopefully it can be merged. |
Hey [automaton82] I guess you were doing the change on Flowise\node_modules\flowise-components\dist\nodes\vectorstores\Milvus instead of packages/components/nodes/vectorstores/Milvus/Milvus_Upsert.ts? |
Allow me to elaborate how i made it work, i had the same issue you have [automaton82], 1) rename flowise folder to anything, 2) git clone repository, 3) cd to flowise, 4) go to packages/components/nodes/vectorstores/Milvus/Milvus_Upsert.ts? Replaced INDEX_NOT_EXIST with IndexNotExist on line 255, 5)Yarn Install 6)Yarn Build. Thats it now it will work. |
@Initonedeb Yes, I fixed the issue this PR fixes manually. But I had a separate build error which is now gone. |
thanks everyone! |
Thanks! |
…dex-not-exist-issue-1135 Build error fixed (TS)
Error: "Property 'INDEX_NOT_EXIST' does not exist on type 'typeof ErrorCode'. Did you mean 'IndexNotExist'?ts(2551)
error.d.ts(39, 5): 'IndexNotExist' is declared here."
in "packages/components/nodes/vectorstores/Milvus/Milvus_Upsert.ts".
Fixed: Replaced INDEX_NOT_EXIST with IndexNotExist
issue described here: #1135