Support global-agent for central proxy configuration #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using environment variable ** https://www.npmjs.com/package/global-agent * Server-Bootstrap on index.js ** import 'global-agent/bootstrap' * added dep in package.json ** global-agent: "^3.0.0
|
thanks @akoo24 ! How do i test this though? |
|
Hi Henry, in our case we have an on-premises Kubernetes installation behind a corporate proxy. This means that for testing purposes, outgoing connections to OpenAi / AzureOpenAI should only be possible via a proxy. In order to redirect outgoing requests centrally via a proxy, the following environment variables must be set at startup (see https://www.npmjs.com/package/global-agent)
If the environment variables are not set, no centralized routing via proxy takes place, Best Regards |
…using environment variable ** Added env variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With central configuration of global agent via environment variables, the proxy agent is included in all node-fetch requests without any code changes and thus it is no longer necessary to implement the proxy URL in each ChatModel. Currently, the ProxyUrl is implemented in ChatOpenAI_ChatModels and as an example is still required in AzureChatOpenAI_ChatModels. The existing proxy mechanism would continue to work if required, because the global agent can be deactivated by a missing environment variable.