Azure OpenAI Embeddings ignores env variable AZURE_OPENAI_BASE_PATH #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akoo24
commented
Nov 4, 2024
akoo24
commented
- Set azureOpenAIBasePath to undefined if empty to enforce usage of env variable AZURE_OPENAI_BASE_PATH in @langchain+openai@0.0.30_encoding@0.1.13_langchain@0.2.11/node_modules/@langchain/openai/dist/embeddings.cjs
* Set azureOpenAIBasePath to undefined if empty to enforce usage of env variable AZURE_OPENAI_BASE_PATH in @langchain+openai@0.0.30_encoding@0.1.13_langchain@0.2.11/node_modules/@langchain/openai/dist/embeddings.cjs
HenryHengZJ
reviewed
Nov 6, 2024
| @@ -71,7 +71,7 @@ class AzureOpenAIEmbedding_Embeddings implements INode { | |||
| azureOpenAIApiInstanceName, | |||
| azureOpenAIApiDeploymentName, | |||
| azureOpenAIApiVersion, | |||
| azureOpenAIBasePath: basePath | |||
| azureOpenAIBasePath: basePath || undefined | |||
There was a problem hiding this comment.
what happens if you dont have basePath specified ? it will automatically becomes undefined? or was it an empty string?
There was a problem hiding this comment.
exactly, basePath is an empty string by default, setting it to undefined instead of empty ensures that env variable AZURE_OPENAI_BASE_PATH is used instead of empty in @langchain+openai@0.0.30_encoding@0.1.13_langchain@0.2.11/node_modules/@langchain/openai/dist/embeddings.cjs
HenryHengZJ
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.