Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add vertex ai #713

Merged
merged 33 commits into from
Aug 9, 2023
Merged

Conversation

Yongtae723
Copy link
Contributor

this pr is combine of #679, #680 and #681.

thank you @HenryHengZJ @chungyau97 for long discussion!
I finally make good PR for adding Vertex AI

…ect credentials. Update GoogleVertexAIEmbedding to handle both cases
@@ -0,0 +1,117 @@
import { ICommonObject, INode, INodeData, INodeParams } from '../../../src/Interface'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the file name same camecase? GoogleVertextAI.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

thank you for pointing out!

@@ -0,0 +1,115 @@
import { ICommonObject, INode, INodeData, INodeParams } from '../../../src/Interface'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename to file and folder name to ChatGoogleVertextAI, just to prevent same name as the one in llms folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course!

@HenryHengZJ
Copy link
Contributor

last one would be a video of using GoogleEmbeddings and ChatVertext for ConversationalRetrievalQAChain would be awesome, will be shown on Twitter demo when push to new release !

@Yongtae723
Copy link
Contributor Author

vertex AI

@HenryHengZJ here!

thank you for sharing my work with Demo video!
Maybe you know my twitter's account so could you mention me when you push?

@davidoort
Copy link

@Yongtae723 thanks so much for this awesome contribution! Will be using this immediately 🙏

@HenryHengZJ
Copy link
Contributor

vertex AI

@HenryHengZJ here!

thank you for sharing my work with Demo video! Maybe you know my twitter's account so could you mention me when you push?

definitely! do you have a high resolution video in google drive like the one you shared last time?

@Yongtae723
Copy link
Contributor Author

thank you!

you can find here

@HenryHengZJ HenryHengZJ merged commit b386743 into FlowiseAI:main Aug 9, 2023
@mdda mdda mentioned this pull request Sep 1, 2023
@kientv
Copy link

kientv commented Sep 21, 2023

vertex AI vertex AI

@HenryHengZJ here!

thank you for sharing my work with Demo video! Maybe you know my twitter's account so could you mention me when you push?

Do Vertex AI support stream with chromadb (typing effect)?

@Yongtae723
Copy link
Contributor Author

Hi @kientv

from my understanding, LangchainJS right now try to implement stream on Vertex AI. langchain-ai/langchainjs#2625
After merged, I can implement into flowise for you. so let me know if you want!

@kientv
Copy link

kientv commented Sep 25, 2023

Thanks, I want it to speed up flowise, because It need more than 5s to response.

Seem that they already merged.
langchain-ai/langchain#10449

@Yongtae723
Copy link
Contributor Author

alright!

@Yongtae723
Copy link
Contributor Author

Oh you mean langchain-ai/langchain#10470 ?

Anyway, I will!

@Yongtae723
Copy link
Contributor Author

Yongtae723 commented Sep 26, 2023

Oh wait, I confused because PR you send me is python libraly.

Flowise is using langchain JS and PR of langchainjs is not merged.
Just in case, I saw the code of langchainjs directly, but streaming implementation has not done yet

does it make sense to you?

@kientv
Copy link

kientv commented Sep 26, 2023

Thanks you, This pull request is still a work in progress
langchain-ai/langchainjs#2625

@kientv
Copy link

kientv commented Oct 31, 2023

Look like that they already merged :)
langchain-ai/langchainjs#2625

hemati pushed a commit to hemati/Flowise that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants