-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add vertex ai #713
Conversation
…ect credentials. Update GoogleVertexAIEmbedding to handle both cases
@@ -0,0 +1,117 @@ | |||
import { ICommonObject, INode, INodeData, INodeParams } from '../../../src/Interface' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep the file name same camecase? GoogleVertextAI.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
thank you for pointing out!
@@ -0,0 +1,115 @@ | |||
import { ICommonObject, INode, INodeData, INodeParams } from '../../../src/Interface' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename to file and folder name to ChatGoogleVertextAI
, just to prevent same name as the one in llms
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course!
last one would be a video of using GoogleEmbeddings and ChatVertext for ConversationalRetrievalQAChain would be awesome, will be shown on Twitter demo when push to new release ! |
@HenryHengZJ here! thank you for sharing my work with Demo video! |
@Yongtae723 thanks so much for this awesome contribution! Will be using this immediately 🙏 |
definitely! do you have a high resolution video in google drive like the one you shared last time? |
thank you! you can find here |
Do Vertex AI support stream with chromadb (typing effect)? |
Hi @kientv from my understanding, LangchainJS right now try to implement stream on Vertex AI. langchain-ai/langchainjs#2625 |
Thanks, I want it to speed up flowise, because It need more than 5s to response. Seem that they already merged. |
alright! |
Oh you mean langchain-ai/langchain#10470 ? Anyway, I will! |
Oh wait, I confused because PR you send me is python libraly. Flowise is using langchain does it make sense to you? |
Thanks you, |
Look like that they already merged :) |
Feature/add vertex ai
this pr is combine of #679, #680 and #681.
thank you @HenryHengZJ @chungyau97 for long discussion!
I finally make good PR for adding Vertex AI