Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowapi module #456

Merged
merged 11 commits into from
Mar 11, 2019
Merged

Flowapi module #456

merged 11 commits into from
Mar 11, 2019

Conversation

greenape
Copy link
Member

@greenape greenape commented Mar 6, 2019

Closes #435
Closes #271

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

  • FlowAPI is now a regular python module
  • App init is no longer done using nested defs
  • Config is now all in one place, rather than slightly randomly scattered reads from os.environ
  • run_query.py is now query_endpoints

@greenape greenape added refactoring FlowAPI Issues related to the FlowKit API labels Mar 6, 2019
@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #456 into master will increase coverage by 0.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   90.92%   90.94%   +0.01%     
==========================================
  Files          90       91       +1     
  Lines        5280     5291      +11     
  Branches      622      622              
==========================================
+ Hits         4801     4812      +11     
  Misses        347      347              
  Partials      132      132
Impacted Files Coverage Δ
flowapi/flowapi/geography.py 100% <ø> (ø)
flowapi/flowapi/stream_results.py 92.59% <ø> (ø)
flowapi/flowapi/jwt_auth_callbacks.py 100% <ø> (ø)
flowapi/flowapi/check_claims.py 85.29% <ø> (ø)
flowapi/flowapi/query_endpoints.py 97.82% <ø> (ø)
flowapi/flowapi/config.py 90.9% <90.9%> (ø)
flowapi/flowapi/main.py 95.89% <95.89%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e935b1a...f4cc558. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #456 into master will increase coverage by 0.01%.
The diff coverage is 95.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   91.06%   91.08%   +0.01%     
==========================================
  Files          92       93       +1     
  Lines        5362     5372      +10     
  Branches      631      631              
==========================================
+ Hits         4883     4893      +10     
  Misses        347      347              
  Partials      132      132
Impacted Files Coverage Δ
flowapi/flowapi/geography.py 100% <ø> (ø)
flowapi/flowapi/stream_results.py 92.59% <ø> (ø)
flowapi/flowapi/jwt_auth_callbacks.py 100% <ø> (ø)
flowapi/flowapi/check_claims.py 85.29% <ø> (ø)
flowapi/flowapi/query_endpoints.py 97.82% <ø> (ø)
flowapi/flowapi/config.py 90.9% <90.9%> (ø)
flowapi/flowapi/main.py 95.83% <95.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2d09a...b2ab0d4. Read the comment docs.

Copy link
Member

@jc-harrison jc-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Mar 11, 2019
@mergify mergify bot merged commit 5f68aba into master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowAPI Issues related to the FlowKit API ready-to-merge Label indicating a PR is OK to automerge refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants