Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: catch exception, when trying to get the original asset, collect and show errors at the end #13

Merged

Conversation

andrehoffmann30
Copy link
Contributor

It can happen that a node references an asset that no longer exists in the system. In this case, an exception occurs when the update command is executed and the execution of the command is aborted. The code has been adjusted so that the exception is caught and the errors that occurred are displayed at the end. This makes it possible to always update the asset usage table and obtain a list of all faulty references. The incorrect references can then be corrected manually in the database.

Copy link

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and pragmatic, looks good to me (didn't test yet)

@crydotsnake crydotsnake requested a review from Sebobo September 23, 2024 07:40
@daniellienert daniellienert merged commit cb23642 into Flowpack:main Oct 17, 2024
@daniellienert daniellienert deleted the task/improve-update-command branch October 17, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants