BUGFIX: Respect the configured value for uriPathSuffix #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdambekalns
requested changes
Aug 30, 2023
| } | ||
| $suffixLength = strlen($this->options['uriPathSuffix']); | ||
| if (substr($uriPath, -$suffixLength) !== $this->options['uriPathSuffix']) { | ||
| throw new Exception\InvalidRequestPathException(sprintf('The request path "%s" doesn\'t contain the configured uriPathSuffix "%s"', $uriPath, $this->options['uriPathSuffix']), 1604912439); |
There was a problem hiding this comment.
Exception codes must never be re-used.
Suggested change
| throw new Exception\InvalidRequestPathException(sprintf('The request path "%s" doesn\'t contain the configured uriPathSuffix "%s"', $uriPath, $this->options['uriPathSuffix']), 1604912439); | |
| throw new Exception\InvalidRequestPathException(sprintf('The request path "%s" doesn\'t contain the configured uriPathSuffix "%s"', $uriPath, $this->options['uriPathSuffix']), 1693381063); |
kdambekalns
changed the title
kdambekalns
added a commit
to kdambekalns/neos-dimensionresolver
that referenced
this pull request
Jul 2, 2024
Inspired by PR Flowpack#11 opened by @c4ll-m3-j4ck this adds the missing piece of the puzzle to support the `uriPathSuffix`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this package, routing is defaulted to routes without appending the chosen uriPathSuffix.
This fix adds the missing check for uriPathSuffix the same way as it is done in
Neos\Neos\Routing\FrontendNodeRoutePartHandler