Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid Ignores transforms when No Controller is used #1389

Closed
spessasus opened this issue Sep 29, 2024 · 1 comment · Fixed by #1392
Closed

Fluid Ignores transforms when No Controller is used #1389

spessasus opened this issue Sep 29, 2024 · 1 comment · Fixed by #1392
Labels
Milestone

Comments

@spessasus
Copy link
Contributor

FluidSynth version

FluidSynth runtime version 2.3.6
Copyright (C) 2000-2024 Peter Hanappe and others.
Distributed under the LGPL license.
SoundFont(R) is a registered trademark of Creative Technology Ltd.

Describe the bug

Sfspec24.pdf, section 8.2.1

0 No Controller
No controller is to be used. The output of this controller module should be treated as
if its value were set to ‘1’. It should not be a means to turn off a modulator.

No controller means essentially a CC of fixed value 127, mapping to 1. Passing 1 through a bipolar negative transform should result in -1, but fluid treats it as 1.

In the attached soundfont, I disable the default pitch modulator and create a custom one with a 12 semitone range. The secondary source is a No controller bipolar negative, effectively -1. It should invert the pitch wheel's pitch, but it doesn't in fluid.

Expected behavior

The attached soundfont's preset "syn" should have inverted pitch wheel with fixed range of 12 semitones. It doesn't.

Steps to reproduce

  1. no_controller.zip
  2. fluidsynth no_controller.sf2 -o synth.gain=1
  3. play with the pitch wheel
  4. it is not inverted like it should
  5. compare results with other modulator compliant synths like polyphone or spessasynth

Additional context

Might be related to #1068

@spessasus spessasus added the bug label Sep 29, 2024
@derselbst derselbst added this to the 2.4 milestone Oct 3, 2024
derselbst added a commit that referenced this issue Oct 3, 2024
particularly when sources are set to 'no controller'.

Addresses #1389
@derselbst
Copy link
Member

I've created a PR for this problem. In my tests with your soundfont, the pitch wheel is now inverted.

@derselbst derselbst linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants