Fix regression in WinMIDI driver #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the lowest two bytes in dwParam1 are the status byte, not the highest; also need to mask with 0xff to get the system message type
|
Kudos, SonarCloud Quality Gate passed!
|
derselbst
changed the title
|
Thanks, sorry for breaking stuff |
|
No problem. It also escaped my attention when reviewing your original PR. Don't worry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1115 I created a bug in the winmidi driver that causes all incoming voice messages to have channel, param1, and param2 = 0. In fluid_winmidi_callback() the check for
msg_param < 0xf0fails for all MIDI messages (I had the byte order of dwParam1 backwards, status byte is the lowest byte, not the highest), so the channel and params are never set.Fixed using the
msg_typemacro to check for voice category message. Also have to mask the status byte with0xfffor system messages to get the type properly.