Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: restore sandboxing options and add PrivateUsers=yes to make them work as user units #1181

Merged
merged 2 commits into from
Nov 5, 2022

Conversation

bluca
Copy link
Contributor

@bluca bluca commented Nov 3, 2022

The alternative is to also remove ProtectSystem, which also requires PrivateUsers. At some point we'll make it implicit, and only a handful of user units use it, so we want to make sure it is intentional to have this and not accidental.

ProtectSystem= and other sandboxing options require a user namespace in
order to work as user units (the user manager does not run as root and
thus without a user namespace it is unable to perform mounts).
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I don't really know about systemd, glad you took care of this :)

@derselbst derselbst merged commit fe956c8 into FluidSynth:master Nov 5, 2022
@bluca bluca deleted the private_users branch November 5, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants