New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jack_driver: last_client reuse fix. #434

Merged

derselbst merged 1 commit into FluidSynth:master from rncbc:jack_driver-last_client-reuse-fix

Sep 20, 2018

Contributor

rncbc commented Sep 20, 2018

Fix last_client reuse logic on new_fluid_jack_client();

fixes qsynth issues on starting more than one single engine with "jack" audio driver (and midi driver is anything else bu "jack");
also fixes qsynth crashes when output peak level meters option are set.

See also #416


          jack_driver: last_client reuse fix.

99e235e

Member

derselbst commented Sep 20, 2018

Oh indeed, that's my bad when attempting to fix a null dereference to strcmp() in 3486bb5, sorry. Thanks for the fix!

derselbst added this to the 2.0-post milestone

derselbst added the bug label

derselbst merged commit fb684aa into FluidSynth:master

derselbst mentioned this pull request

Registers in JACK as two elements: Audio and Midi, instead of just one #510

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug