Update fluid_dsound.c

[carlo-bramini]

I did some quick improvements to DirectSound driver:

• fluid_dsound_audio_run() and fluid_win32_error() are now static functions.

• WAVEFORMATEX is not required by DirectSound during the playback. We do not need it anymore after calling ::SetFormat(), so allocating this structure dynamically inside driver structure is useless.

• Implemented support for float sample type.

• Uses an event object for handling the end of thread, it allows to combine the quit event with the later wait in milliseconds in a single block.

• Calculates the amount of milliseconds to sleep rather than sleeping always for one millisecond.

• Fix an error into a FLUID_LOG() call.

• Fix handle leak of the thread, now it is correctly closed with CloseHandle().

• ExitThread() is a nonsense in that position, since the thread is already exiting.

[derselbst]

Looks good. Have you tested it? Am Fr., 28. Sep. 2018 um 19:53 Uhr schrieb carlo-bramini < notifications@github.com>:

…

I did some quick improvements to DirectSound driver: - fluid_dsound_audio_run() and fluid_win32_error() are now static functions. - WAVEFORMATEX is not required by DirectSound during the playback. We do not need it anymore after calling ::SetFormat(), so allocating this structure dynamically inside driver structure is useless. - Implemented support for float sample type. - Uses an event object for handling the end of thread, it allows to combine the quit event with the later wait in milliseconds in a single block. - Calculates the amount of milliseconds to sleep rather than sleeping always for one millisecond. - Fix an error into a FLUID_LOG() call. - Fix handle leak of the thread, now it is correctly closed with CloseHandle(). - ExitThread() is a nonsense in that position, since the thread is already exiting. ------------------------------ You can view, comment on, or merge this pull request online at: #435 Commit Summary - Update fluid_dsound.c File Changes - *M* src/drivers/fluid_dsound.c <https://github.com/FluidSynth/fluidsynth/pull/435/files#diff-0> (115) Patch Links: - https://github.com/FluidSynth/fluidsynth/pull/435.patch - https://github.com/FluidSynth/fluidsynth/pull/435.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#435>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHxloMxHryBNU8PFcddvdfb_fL4Kyndtks5ufmIfgaJpZM4W_IfI> .

[carlo-bramini]

I'm using it right now, it seems to be fine.

[derselbst]

Ok, thanks!