Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only retrieve modification time once and remove warning if failed #485

Merged
merged 1 commit into from
Dec 19, 2018

Commits on Dec 15, 2018

  1. Only retrieve modification time once and remove warning if failed

    This change removes the warning message if retrieving the soundfont file
    modification time fails in the sample cache loader. The warning made sense
    while we didn't have mtime support on all platforms, but after switching
    to GLibs g_stat, it's no longer needed.
    
    To reduce the number of calls to fluid_get_file_modification_time and also
    get rid of a possible race condition, getting the mtime has been moved to
    fluid_samplecache_load.
    
    This change also fixes #483 because it removes the bogus warning messages
    if a soundfont was loaded from memory by abusing the filename to store a
    pointer.
    mawe42 committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    8004152 View commit details
    Browse the repository at this point in the history