Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More efficient and unlimited implementation of fluid_ct2hz() #569

Merged
merged 9 commits into from
Oct 22, 2019
Merged

More efficient and unlimited implementation of fluid_ct2hz() #569

merged 9 commits into from
Oct 22, 2019

Commits on Oct 18, 2019

  1. More efficient and unbound implementation of fluid_ct2hz()

    @derselbst
    derselbst committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    2b585f0 View commit details
    Browse the repository at this point in the history

  2. use ldexp()

    @derselbst
    derselbst committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    ef9e081 View commit details
    Browse the repository at this point in the history

  3. prefer FLUID_POW to pow()

    @derselbst
    derselbst committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    28968fd View commit details
    Browse the repository at this point in the history

  4. Revert "use ldexp()" 

    This reverts commit ef9e081.

"Although ldexp, scalbn and scalbln are specified to perform
the operation efficiently, on many implementations they are
less efficient than multiplication or division by a power of
two using arithmetic operators."

Which was proven by using VTune.
    @derselbst
    derselbst committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    87cfc56 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. update regression test

    @derselbst
    derselbst committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    13e7ca6 View commit details
    Browse the repository at this point in the history

  2. fix broken comparison

    @derselbst
    derselbst committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    8bbbf30 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2019

  1. remove call to div() 

    turned out to be expensive
    @derselbst
    derselbst committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    190ee28 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. make sure left shift wraps around

    @derselbst
    derselbst committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    3c1d3f8 View commit details
    Browse the repository at this point in the history

  2. fix unit test

    @derselbst
    derselbst committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    b038870 View commit details
    Browse the repository at this point in the history