Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make clean in libspud for CX1 #142

Merged
merged 2 commits into from
Aug 4, 2017
Merged

Fix to make clean in libspud for CX1 #142

merged 2 commits into from
Aug 4, 2017

Conversation

jmn114
Copy link
Contributor

@jmn114 jmn114 commented Dec 14, 2016

Hi Tim,

James and I spotted a problem when cleaning the libspud library in CX1.

We added the abspath to the SPUDLIB so it returns an absolute name of the library without getting confuse with the CX1 path names.

@jmn114 jmn114 requested review from tmbgreaves and jrper December 14, 2016 15:50
Copy link
Contributor

@jrper jrper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this actually needs to be
($(abspath @SPUDLIB@),$(abspath lib/libspud.a))
although I'm now slightly surprised you said it clears the problem on CX1.

Copy link
Contributor

@tmbgreaves tmbgreaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with James' comment and happy for this to be merged once that's fixed.

@stephankramer
Copy link
Contributor

What did we decide again on how we're going to deal with maintaining libspud/diamond? Move it to git? Was I going to contact @cianwilson about it?

@tmbgreaves
Copy link
Contributor

Hi @stephankramer - after some discussion at the dev meeting yesterday could you ask @cianwilson if he's interested in continuing to maintain libspud/diamond on launchpad If not, we were debating between cloning the repository over to Fluidity on github and having a local maintained version, or just going with the version already in the Fluidity tree which is where fixes have been going recently anyway. If you and/or Cian have any input/thoughts there please do post them :-)

@jrper jrper merged commit f3a6eb9 into master Aug 4, 2017
@jrper jrper deleted the make_clean_fix branch August 7, 2017 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants