Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include REASON_FUSION/RITUAL/... in msg_move of special summon #283

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

melvinzhang
Copy link

Before: the msg_move of pendulum summoned card show REASON_SPSUMMON
After: the msg_move of pendulum summoned card shows REASON_SPSUMMON+REASON_PENDULUM

This PR adds the reason in msg_move for all the six named special summon types.

For issue #282

@purerosefallen
Copy link
Collaborator

Is is PR for some specific clients showing summon reasons for client effect?

@melvinzhang
Copy link
Author

Yes, it is.

@melvinzhang
Copy link
Author

Also for consistency, as special summon reason are given for material move message but not for move message of the summoned card.

@purerosefallen
Copy link
Collaborator

which slim?

@melvinzhang
Copy link
Author

YGO Omega.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants