-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aux.SelectPDS and fixed related cards #2541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
significantly harder to read
I tried something like |
@mercury233 how about |
it is obviously unacceptable to add such wrap, please use appropriate method |
so any better ways? |
nobody will know what is P or what is Preserve |
Are you arguing about the naming problem, or you want to have a brand new way to solve this problem? Please think of ways to solve the problem, rather than closing other's PR or deleting other's branch. |
Considering the number of cards should be changed, we have to do something on aux. If you could think of a better name, you could do a direct replacement on those files. |
Please change "we" to "I" (you) |
Let's consider something real. Which name would you like to use rather than the currenct suffix Or if you want another way, could you introduce it? |
How about in THIS PR? I think something like |
I think it is better to do something to remove |
|
fixed this.