Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SrvPro Menu #2118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add SrvPro Menu #2118

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 25, 2018

srvpro

@edo9300
Copy link
Contributor

edo9300 commented Jun 25, 2018

I think you should do a check and see if there's at least 1 server listed in the configs, otherwise hide the server tab

@mercury233
Copy link
Collaborator

Thank you!

But I think ygopro shouldn't be designed for any specific external project, it should be compatible with other servers, even though we may design some new APIs for it.

Take creating room for example, we can make a HTTP POST of JSON with room info to the server, and wait the server to return ip and password for the created room.

BTW, if I add server to ygopro, it will have room list. Here is a quick design:

2

@purerosefallen
Copy link
Collaborator

purerosefallen commented Jun 25, 2018

Does it support SRVPro reconnecting function?
Also it needs to send http request to get the roomlist.
(And is it possible to support playing in MyCard without MyCard client?)

@purerosefallen
Copy link
Collaborator

In addition, We need to add an option to let users add servers.

@purerosefallen
Copy link
Collaborator

I had a quick test of it, but it crashed after enter a server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants