Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore STOC_GAME_MSG outside duel #2293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mercury233
Copy link
Collaborator

Sometimes the client still receive STOC_GAME_MSG when changing side, and processing that message may crash the client because the field is cleared.

@DailyShana
Copy link
Contributor

sometimes is what time? the server side should guarantee the correctness of messages

@mercury233
Copy link
Collaborator Author

if the order is guaranteed, the client can safely ignore that msg

@DailyShana
Copy link
Contributor

what order?
If the client receives STOC_GAME_MSG when changing side, there must be a bug in the server

@purerosefallen
Copy link
Collaborator

There is 1 case. Sometimes MSG_WIN would be received while changing side when opponent quits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants