Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Action Triggers #145

Closed
wants to merge 11 commits into from
Closed

Conversation

pinkeshmars
Copy link
Collaborator

New Action Triggers

Linear ticket and magic word Fixes DEVR-602

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

stackblitz bot commented Sep 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot requested a review from PoojaB26 September 19, 2024 10:52
@PoojaB26 PoojaB26 changed the base branch from main to ffdc-features September 23, 2024 10:20

### Widget Specific Triggers

Widget specific triggers are available on certain widgets. Here are they:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Widget specific triggers are available on certain widgets. Here are they:
Certain widgets offer specific triggers that activate based on user interactions or device events. These triggers enable developers to define custom behaviors for various situations. Below are examples of widget-specific triggers:


Tap gestures have a simpler lifecycle, focusing primarily on detecting taps and whether they complete or get canceled. Here's how the tap lifecycle works:

1. **Start**: This stage begins when the user places their finger on the screen to initiate a tap. For example: `onTapDown` is triggered when the user touches the screen to start a tap.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Start, End made sense for drag gestures because all of the gestures are named similarly, why do we need to use the same terminology for this? Why not use Down, Up, Cancel terminology directly? Or maybe we use Start/Down, End/Up, Cancel instead?

This applies to the diagram too. And it would be great to showcase that onTap is called after onTapUp (in the diagram)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, no worries. updated!


- **Global Position X**: The x-coordinate of the pointer relative to the left edge of the screen when the gesture was triggered.
- **Global Position Y**: The y-coordinate of the pointer relative to the top edge of the screen when the gesture was triggered.
- **Local Position X**: The x-coordinate of the pointer relative to the left edge of the widget that detected the gesture.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

widget that detected the gesture.

Isnt it the widget that has the action triggers applied on? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both are the same, it only detects if it has triggers applied. but 'action triggers applied on' is more clear, so made a slight change.

@pinkeshmars
Copy link
Collaborator Author

Hi @PoojaB26, Review comments are addressed now. You can take a look again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants