Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2 #246

Merged
merged 14 commits into from
Jan 22, 2025
Merged

Merge v2 #246

merged 14 commits into from
Jan 22, 2025

Conversation

pinkeshmars
Copy link
Collaborator

@pinkeshmars pinkeshmars commented Jan 3, 2025

Description

Merge V2

Linear ticket and magic word Fixes DEVR-732

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

stackblitz bot commented Jan 3, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pinkeshmars pinkeshmars changed the title Adding Merge v2 info (WIP) Adding Merge v2 info Jan 10, 2025
@pinkeshmars pinkeshmars marked this pull request as ready for review January 10, 2025 10:31
@github-actions github-actions bot requested a review from PoojaB26 January 10, 2025 10:31
@pinkeshmars pinkeshmars changed the title Adding Merge v2 info Merge v2 Jan 10, 2025
Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit changes.


- **Filter Files:** You can use filters to narrow down the list of YAML files based on specific criteria:

- **All Files (Unchanged Files)**: Shows every YAML file in the project.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not every file -- just the ones without changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

height: 0,
width: '100%'}}>
<iframe
src="https://demo.arcade.software/hphsdsKGyT8Vid7c0NxX?embed&show_copy_link=true"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was recorded from an outdated UI. Please take a look at the new one.

- **Branch Information**: At the top of the merge interface, you’ll see exactly which branches are being merged. You have two options for merging directions:
- **Parent → Child**: Pulls changes down from the parent into the child branch, often used to keep a feature branch in sync with the parent branch.
- **Child → Parent**: Pushes features (or other changes) from the child branch back up to the parent, commonly done once a feature is ready to go into the parent branch.
- **YAML Validation Errors**: Occurs when manual edits to the project files produce invalid syntax. Clicking on these errors should redirect you to the specific file. Invalid lines will be underlined in red within the file, and, you **cannot** complete the merge while YAML errors exist.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Occurs when manual edits to the project files produce invalid syntax.

This is incorrect. Even without any manual intervention, validation errors can occur. This simply means that the resulting data is not in a "Flutterflow-friendly" format

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @victoriahuang1 I didn't understand this fully. Could you please elaborate with an example?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, if there are a total of 2 pages, and each branch deletes a different one, then there would be no pages left. There are no conflicts, but the fact that there are 0 pages causes validation errors

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Updated! Thanks.

@leighajarett leighajarett merged commit c451424 into main Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants