Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added design system #34

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Added design system #34

merged 2 commits into from
Jun 7, 2024

Conversation

pinkeshmars
Copy link
Collaborator

Description

Added design system

Linear ticket and magic word Fixes DEVR-342

Type of change

  • Typo fix
  • New feature
  • Removed outdated references

@pinkeshmars pinkeshmars requested a review from PoojaB26 June 3, 2024 05:51
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jun 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot requested a review from johnbhiggins7 June 3, 2024 05:51
@PoojaB26
Copy link
Collaborator

PoojaB26 commented Jun 6, 2024 •
edited
Loading

Are the videos here from old docs? And if yes, they must be Loom videos right? Or did we record them again? I'm confused. @pinkeshmars

PoojaB26
PoojaB26 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ony nit: please add a <p> tag after Arcades so the texts are not sticking with it. I've made the changes and pushed.

@PoojaB26 PoojaB26 merged commit f973695 into main Jun 7, 2024
@PoojaB26 PoojaB26 deleted the pinkesh/design-system branch June 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoojaB26 PoojaB26 PoojaB26 approved these changes

@johnbhiggins7 johnbhiggins7 Awaiting requested review from johnbhiggins7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinkeshmars @PoojaB26