Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windows #28

Merged
merged 6 commits into from
Sep 9, 2020
Merged

Support windows #28

merged 6 commits into from
Sep 9, 2020

Conversation

wasabeef
Copy link
Member

@wasabeef wasabeef commented Sep 8, 2020

What does this change?

What is the value of this and can you measure success?

  • Pass CI on Windows.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #28 into main will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   95.54%   95.59%   +0.04%     
==========================================
  Files          15       15              
  Lines         359      363       +4     
==========================================
+ Hits          343      347       +4     
  Misses         16       16              
Impacted Files Coverage Δ
lib/flutter_generator.dart 70.45% <100.00%> (+2.16%) ⬆️
lib/src/generators/assets_generator.dart 100.00% <100.00%> (ø)
lib/src/generators/generator_helper.dart 100.00% <100.00%> (ø)
lib/src/settings/flutter_gen.dart 95.45% <100.00%> (ø)
lib/src/utils/camel_case.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7ccb7...a10c3b1. Read the comment docs.

@wasabeef wasabeef changed the title Support windows [WIP] Support windows Sep 8, 2020
@wasabeef wasabeef changed the title [WIP] Support windows Support windows Sep 8, 2020
@lcdsmao lcdsmao self-requested a review September 9, 2020 04:01
@wasabeef wasabeef merged commit 3df19fe into main Sep 9, 2020
@wasabeef wasabeef deleted the support-windows branch September 9, 2020 04:03
@wasabeef wasabeef mentioned this pull request Sep 9, 2020
@wasabeef wasabeef added this to the 1.0.2 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants