Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Key parameter in image() and svg() #51

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

tuanvugoodmoney
Copy link
Contributor

What does this change?

Add support to specify a Key for convenience methods image() and svg().

What is the value of this and can you measure success?

Clients who need to assign a key to the Image or SvgPicture could use the convenience methods like Assets.images.my_image.image(key: Key("mykey")), rather than forcing them to do something like Image(key: Key("mykey"), Assets.images.my_image).

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #51 (8adf7b5) into main (1fca00d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          16       16           
  Lines         441      441           
=======================================
  Hits          439      439           
  Misses          2        2           
Impacted Files Coverage Δ
lib/src/generators/assets_generator.dart 100.00% <ø> (ø)
...b/src/generators/integrations/svg_integration.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fca00d...8adf7b5. Read the comment docs.

@wasabeef wasabeef merged commit 6949852 into FlutterGen:main Nov 14, 2020
@wasabeef
Copy link
Member

@tuanvugoodmoney

Thanks for your great job.

@wasabeef wasabeef modified the milestones: 1.2.1, 1.2.2 Nov 14, 2020
@wasabeef wasabeef mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants