Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(generator): workaround nnbd #75 #83

Merged
merged 1 commit into from
Feb 20, 2021
Merged

chore(generator): workaround nnbd #75 #83

merged 1 commit into from
Feb 20, 2021

Conversation

wasabeef
Copy link
Member

@wasabeef wasabeef commented Feb 19, 2021

What does this change?

Fixed: Issue #75

MEMO
If when forgot to add --no-sound-null-safety argument,

Xcode's output:
↳
    lib/gen/assets.gen.dart:1:1: Error: A library can't opt out of null safety by default, when using sound null safety.
    // @dart = 2.10
    ^^^^^^^^^^^^^^^
    lib/gen/colors.gen.dart:1:1: Error: A library can't opt out of null safety by default, when using sound null safety.
    // @dart = 2.10
    ^^^^^^^^^^^^^^^
    lib/gen/fonts.gen.dart:1:1: Error: A library can't opt out of null safety by default, when using sound null safety.
    // @dart = 2.10

What is the value of this and can you measure success?

  • Pass CI

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #83 (f605936) into main (7eac2f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          16       16           
  Lines         506      506           
=======================================
  Hits          497      497           
  Misses          9        9           
Impacted Files Coverage Δ
packages/core/lib/generators/generator_helper.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eac2f4...f605936. Read the comment docs.

@wasabeef wasabeef changed the title chore(generator): workaround nnbd #75 [wip] chore(generator): workaround nnbd #75 Feb 19, 2021
@wasabeef wasabeef changed the title [wip] chore(generator): workaround nnbd #75 chore(generator): workaround nnbd #75 Feb 19, 2021
@wasabeef wasabeef merged commit 992fd75 into main Feb 20, 2021
@wasabeef wasabeef deleted the workaround-nnbd branch February 20, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants