-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Null-Safety #91
Conversation
@@ -34,5 +34,5 @@ void main(List<String> args) { | |||
} | |||
|
|||
final pubspecPath = safeCast<String>(results['config']); | |||
FlutterGenerator(File(pubspecPath).absolute).build(); | |||
FlutterGenerator(File(pubspecPath!).absolute).build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -97,7 +98,7 @@ class _Color { | |||
|
|||
_Color.fromXmlElement(XmlElement element) | |||
: this( | |||
element.getAttribute('name'), | |||
element.getAttribute('name')!, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 % dart packages/command/bin/flutter_gen_command.dart --config example/pubspec.yaml
Error: Cannot run with sound null safety, because the following dependencies
don't support null safety:
- package:dart_style
- package:merge_map
- package:analyzer
- package:pub_semver
- package:color
- package:_fe_analyzer_shared
- package:watcher
- package:cli_util
- package:convert
- package:pedantic
- package:glob
- package:async
- package:package_config
For solutions, see https://dart.dev/go/unsound-null-safety |
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
===========================================
- Coverage 98.02% 52.05% -45.97%
===========================================
Files 16 43 +27
Lines 506 3694 +3188
===========================================
+ Hits 496 1923 +1427
- Misses 10 1771 +1761
Continue to review full report at Codecov.
|
What does this change?
What is the value of this and can you measure success?