Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

セッション詳細画面の作成 #147

Merged
merged 29 commits into from
Sep 28, 2023
Merged

セッション詳細画面の作成 #147

merged 29 commits into from
Sep 28, 2023

Conversation

iseruuuuu
Copy link
Contributor

@iseruuuuu iseruuuuu commented Sep 9, 2023 •
edited
Loading

Issue

#147

Overview (Required)

  • session_detail_pageの作成

Links

Screenshot

Before After

@iseruuuuu iseruuuuu self-assigned this Sep 9, 2023
@iseruuuuu iseruuuuu added the feature New feature or request label Sep 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit a46b57f):

https://flutterkaigi-2023-preview--pr147-feature-session-deta-i0p1a1do.web.app

(expires Thu, 05 Oct 2023 06:38:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec86c184da0140e1a174c92c6d39f7a77720a028

@iseruuuuu iseruuuuu marked this pull request as draft September 9, 2023 00:08
This was referenced Sep 9, 2023
Closed
Closed
@iseruuuuu iseruuuuu changed the title [WIP]session_detail_pageの作成 [WIP]セッション詳細画面の作成 Sep 9, 2023
iseruuuuu
iseruuuuu commented Sep 17, 2023
View reviewed changes
lib/app/home_page.dart Outdated Show resolved Hide resolved
YumNumm
YumNumm reviewed Sep 24, 2023
View reviewed changes
Copy link
Contributor

@YumNumm YumNumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iseruuuuu
実装進めてくださりありがとうございます!
いくつか気になった点をコメントさせて頂きました🙏
確認よろしくお願いします🙇‍♂

lib/core/components/time_table.dart Outdated Show resolved Hide resolved
lib/app/home_page.dart Show resolved Hide resolved
lib/features/session_page/session_detail/session_detail_desktop.dart Outdated Show resolved Hide resolved
lib/features/session_page/session_detail/session_detail_desktop.dart Outdated Show resolved Hide resolved
lib/core/components/time_table.dart Outdated Show resolved Hide resolved
lib/core/components/time_table.dart Outdated Show resolved Hide resolved
lib/core/components/time_table.dart Outdated Show resolved Hide resolved
lib/core/components/time_table.dart Outdated Show resolved Hide resolved
lib/core/components/time_table.dart Outdated Show resolved Hide resolved
lib/core/components/time_table.dart Outdated Show resolved Hide resolved
YumNumm
YumNumm reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@YumNumm YumNumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iseruuuuu
1点追加でコメントしましたので 確認よろしくお願いします🙏

lib/core/components/time_table.dart Outdated Show resolved Hide resolved
@iseruuuuu iseruuuuu changed the base branch from main to feature/sesion September 27, 2023 08:52
iseruuuuu added 11 commits September 27, 2023 17:56
fix:背景色を変更しました。
c6bb5bf
fix: Session詳細Widgetの上部と同様の実装なので 共通化しました
ef32415
fix: time_table.dartをfeature/session_detailに移動しました。
2cf1466
fix: DeskTop -> Desktop
a6f73e0
fix: 横幅計算は上流のCustomScrollView部分で行っているためwidthを削除しました。
47f3ffc
fix: Chip Widgetを使用して実装を修正しました。
97c1458
fix:OutlinedButtonを利用した修正を行いました。
33c0ec8
fix: elseを削除しても問題なさそうだったので修正しまいた。
5413c53
fix: time_tableにborderをつけました
564d5e7
Merge branch 'feature/sesion' into feature/session_detail_page
593698e 
# Conflicts:
#	lib/app/home_page.dart
add: Headerを共通なものに差し替えて、不必要な変数などを削除しました。
aed8d46
@iseruuuuu iseruuuuu requested a review from YumNumm September 28, 2023 06:08
@iseruuuuu iseruuuuu marked this pull request as ready for review September 28, 2023 06:09
@iseruuuuu
Copy link
Contributor Author

残りのタスク

  • 遷移まわり
  • セッション詳細データの引数が正しいかどうかの確認
  • トーク概要のMarkdownや文字の位置調整などの修正

@iseruuuuu iseruuuuu changed the title [WIP]セッション詳細画面の作成 セッション詳細画面の作成 Sep 28, 2023
YumNumm
YumNumm approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@YumNumm YumNumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

別PRにて作業するため 一旦LGTMです!
LGTM

@YumNumm YumNumm merged commit 08e573f into feature/session Sep 28, 2023
4 checks passed
@YumNumm YumNumm deleted the feature/session_detail_page branch September 28, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YumNumm YumNumm YumNumm approved these changes

@daiki1003 daiki1003 Awaiting requested review from daiki1003

@tatsutakein tatsutakein Awaiting requested review from tatsutakein

@blendthink blendthink Awaiting requested review from blendthink

@jiyuujin jiyuujin Awaiting requested review from jiyuujin

Assignees

@iseruuuuu iseruuuuu

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iseruuuuu @YumNumm @daiki1003