Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yamlduplicate_ignoreの除外を追加 #165

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

YumNumm
Copy link
Contributor

@YumNumm YumNumm commented Sep 21, 2023

Overview (Required)

  • duplicate_ignoreを追加
    • riverpod_generator生成クラスが// ignore_for_file: type=lintを作成する関係で 重複したignoreが生成されてしまいます
    • freezedとの兼ね合いもありtype=lintは無効にしたくない

Links

@YumNumm YumNumm marked this pull request as ready for review September 21, 2023 07:34
@github-actions github-actions bot added the bug Something isn't working label Sep 21, 2023
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit aa05fed):

https://flutterkaigi-2023-preview--pr165-fix-build-runner-dup-scvk1zpm.web.app

(expires Thu, 28 Sep 2023 07:36:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec86c184da0140e1a174c92c6d39f7a77720a028

@YumNumm YumNumm mentioned this pull request Sep 21, 2023
Copy link
Contributor

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@blendthink
Copy link
Contributor

@YumNumm
これって再生成しなくていいんでしたっけ?

@YumNumm YumNumm merged commit 7c74eeb into main Sep 21, 2023
6 checks passed
@YumNumm YumNumm deleted the fix/build-runner-duplicate-ignore branch September 21, 2023 14:06
@blendthink
Copy link
Contributor

あ、こちらで対応すればよさそうですね、、!
#163

@YumNumm
Copy link
Contributor Author

YumNumm commented Sep 21, 2023

あ!!! 再生成忘れておりました... (もう一度build_runnerを動かしても ソースコードが変わっていないので スキップされてしまうのですね..)

あ、こちらで対応すればよさそうですね、、!
#163

こちらで対応します🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants