Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

スポンサープランヘッダー関連の変更 #168

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

tatsutakein
Copy link
Contributor

Issue

Overview (Required)

スポンサープランヘッダー関連の変更を実施します。

  • SponsorRankHeader → SponsorPlanHeader へリネーム
  • SponsorPlanHeader のコンストラクタを SponsorPlan に基づいた形に変更
  • SponsorPlan のファイル名の変更漏れ対応

Links

Screenshot

Before After

@github-actions github-actions bot added the improve Improve Proposal label Sep 22, 2023
@tatsutakein tatsutakein marked this pull request as ready for review September 22, 2023 03:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Visit the preview URL for this PR (updated for commit 7a669a7):

https://flutterkaigi-2023-preview--pr168-improve-refactor-spo-6hql4hfd.web.app

(expires Fri, 29 Sep 2023 05:33:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec86c184da0140e1a174c92c6d39f7a77720a028

Copy link
Contributor

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点コメントしていますが、大きく問題なさそうなため Approve させていただきます!
ご対応ありがとうございます!

lib/features/sponsor/ui/sponsor_plan_header.dart Outdated Show resolved Hide resolved
@tatsutakein
Copy link
Contributor Author

ご確認いただきありがとうございました!
CI が無事に終了し次第マージいたします。

@tatsutakein tatsutakein merged commit 4c8936e into main Sep 22, 2023
4 checks passed
@tatsutakein tatsutakein deleted the improve/refactor-sponsorPlanHeader branch September 22, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Improve Proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants