Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10/27以降の開催終了後の設計・実装 #212

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Conversation

iseruuuuu
Copy link
Contributor

@iseruuuuu iseruuuuu commented Oct 14, 2023

Issue

  • close #221

Overview (Required)

  • 10/27以降の開催終了後の設計・実装をしました

  • マージは10/27ごろにする予定です。

  • Andorid・iOS アプリへのリンクを取り込む実装も必要ですが実装されましたら取り込んで追記予定です

Links

Screenshot

Before After

@iseruuuuu iseruuuuu marked this pull request as ready for review October 14, 2023 05:06
@github-actions github-actions bot added the feature New feature or request label Oct 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023

Visit the preview URL for this PR (updated for commit 1d67136):

https://flutterkaigi-2023-preview--pr212-feature-finish-10-27-7jt0m4ol.web.app

(expires Thu, 02 Nov 2023 14:22:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec86c184da0140e1a174c92c6d39f7a77720a028

@iseruuuuu iseruuuuu marked this pull request as draft October 14, 2023 05:09
@iseruuuuu
Copy link
Contributor Author

iseruuuuu commented Oct 14, 2023

残りのタスク

  • アーカイブのURLを差し替える(まだ用意していないらしい)
  • スマホ版のボタンのサイズを調整する
  • Andorid・iOS アプリへのリンクを取り込む

Sorry, something went wrong.

@iseruuuuu iseruuuuu changed the title [WIP]10/27以降の開催終了後の設計・実装(10/27日ごろにマージ予定) [WIP]10/27以降の開催終了後の設計・実装 Oct 14, 2023
lib/core/components/wanted.dart Outdated Show resolved Hide resolved
@iseruuuuu iseruuuuu requested a review from YumNumm October 20, 2023 04:20
@iseruuuuu iseruuuuu marked this pull request as ready for review October 20, 2023 04:20
@iseruuuuu iseruuuuu requested review from daiki1003, tatsutakein, blendthink and a team and removed request for daiki1003, tatsutakein and blendthink October 20, 2023 04:22
@iseruuuuu iseruuuuu changed the title [WIP]10/27以降の開催終了後の設計・実装 10/27以降の開催終了後の設計・実装 Oct 20, 2023
@iseruuuuu iseruuuuu requested a review from blendthink October 21, 2023 12:50
Copy link
Contributor

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iseruuuuu
いくつか追加でコメントさせていただきましたのでご確認お願いします 🙏
その他は問題ないかなと思いました!

lib/features/ticket/ui/ticket_section.dart Outdated Show resolved Hide resolved
lib/core/components/wanted.dart Outdated Show resolved Hide resolved
lib/core/components/wanted.dart Outdated Show resolved Hide resolved
@blendthink blendthink merged commit 5ccbe61 into main Oct 26, 2023
@blendthink blendthink deleted the feature/finish_10_27 branch October 26, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants