Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11/10以降の開催終了後の設計・実装 #215

Merged
merged 4 commits into from
Nov 10, 2023
Merged

11/10以降の開催終了後の設計・実装 #215

merged 4 commits into from
Nov 10, 2023

Conversation

iseruuuuu
Copy link
Contributor

@iseruuuuu iseruuuuu commented Oct 28, 2023 •
edited
Loading

Issue

  • close #255

Overview (Required)

  • hands-on-event セクションの文言を以下に変更する
    今年のハンズオンは10月26日をもって終了しました。多くの皆様にご参加いただき誠にありがとうございました。
  • hands-on-event セッションのタイトルの文言を以下に変更する
    「Thanks for joining us!」
  • HomePageに「FlutterKaigi2023は終了しました。たくさんの方にご参加いただきありがとうございました。」のSnackBarを追加する
  • Announcement セクションの削除

Links

確認事項

  • マージするのは11月10日にする

@github-actions github-actions bot added the feature New feature or request label Oct 28, 2023
@iseruuuuu iseruuuuu requested a review from a team October 28, 2023 05:29
@iseruuuuu iseruuuuu marked this pull request as ready for review October 28, 2023 05:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 494a312):

https://flutterkaigi-2023-preview--pr215-feature-finish-11-10-guw0qdcf.web.app

(expires Thu, 09 Nov 2023 07:13:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec86c184da0140e1a174c92c6d39f7a77720a028

@blendthink
Copy link
Contributor

@iseruuuuu
チケットの更新漏れで恐縮ですが、 Announcement セクションの削除をお願いします 🙏

@iseruuuuu
Copy link
Contributor Author

承知いたしましたー！！
早めのご連絡のおかげで余裕を持って対応できそうです🙇

@iseruuuuu
Copy link
Contributor Author

@blendthink
Announcement セクションの削除の実装が完了致しましたので、お手隙の際にご確認お願いします🙇
494a312

blendthink
blendthink approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です！
マージしないようにお気をつけください、、！
(ドラフトに変更しておくのがいいかも)

@iseruuuuu iseruuuuu marked this pull request as draft November 3, 2023 00:15
@iseruuuuu
Copy link
Contributor Author

LGTMいただきありがとうございます！！！
念の為に11月10日前まではdraftにしておきます！

@iseruuuuu iseruuuuu marked this pull request as ready for review November 10, 2023 23:33
@iseruuuuu
Copy link
Contributor Author

こちらのPRですが、11日を過ぎたのでマージさせていただきます！！！

@iseruuuuu iseruuuuu merged commit 8e90953 into main Nov 10, 2023
4 checks passed
@iseruuuuu iseruuuuu deleted the feature/finish_11_10 branch November 10, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blendthink blendthink blendthink approved these changes

Assignees

@iseruuuuu iseruuuuu

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iseruuuuu @blendthink