Broken link fixes #2209
Open
Broken link fixes #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CONTRIBUTING.md
ToucheSir
reviewed
Mar 14, 2023
| @@ -42,8 +42,8 @@ Before you start contributing to Flux, you need the following tools: | |||
| If you need to learn about Julia and Flux, then you can check out the following resources: | |||
|
|
|||
| * [JuliaAcademy](https://juliaacademy.com/) introductory courses to Julia and Flux | |||
| * Flux’s official [Getting Started](https://fluxml.ai/getting_started.html) tutorial | |||
| * [Deep Learning with Flux - A 60 Minute Blitz](https://fluxml.ai/tutorials/2020/09/15/deep-learning-flux.html): a quick intro to Flux loosely based on PyTorch’s tutorial | |||
| * Flux’s official [Getting Started](https://docs.flux.ai/Introduction/flux-walkthrough-project) tutorial | |||
There was a problem hiding this comment.
Thanks! This link looks completely unrelated, however.
mcabbott
reviewed
Mar 14, 2023
| * Flux’s official [Getting Started](https://fluxml.ai/getting_started.html) tutorial | ||
| * [Deep Learning with Flux - A 60 Minute Blitz](https://fluxml.ai/tutorials/2020/09/15/deep-learning-flux.html): a quick intro to Flux loosely based on PyTorch’s tutorial | ||
| * Flux’s official [Getting Started](https://docs.flux.ai/Introduction/flux-walkthrough-project) tutorial | ||
| * [Deep Learning with Flux - A 60 Minute Blitz](http://fluxml.ai/Flux.jl/stable/tutorials/2020-09-15-deep-learning-flux/): a quick intro to Flux loosely based on PyTorch’s tutorial |
There was a problem hiding this comment.
This link does work, but IMO the version with most hope of being up to date (or being updated) is https://github.com/FluxML/model-zoo/blob/master/tutorials/60-minute-blitz/60-minute-blitz.jl (and the one in the docs should be removed).
mcabbott
reviewed
Mar 14, 2023
| * Flux’s official [Getting Started](https://fluxml.ai/getting_started.html) tutorial | ||
| * [Deep Learning with Flux - A 60 Minute Blitz](https://fluxml.ai/tutorials/2020/09/15/deep-learning-flux.html): a quick intro to Flux loosely based on PyTorch’s tutorial | ||
| * Flux’s official [Getting Started](https://docs.flux.ai/Introduction/flux-walkthrough-project) tutorial | ||
| * [Deep Learning with Flux - A 60 Minute Blitz](http://fluxml.ai/Flux.jl/stable/tutorials/2020-09-15-deep-learning-flux/): a quick intro to Flux loosely based on PyTorch’s tutorial | ||
| * [Flux Model Zoo](https://github.com/FluxML/model-zoo) showcases various demonstrations of models that you can reuse with your own data | ||
| * [Flux’s official documentation](https://fluxml.ai/Flux.jl/stable/) |
There was a problem hiding this comment.
Maybe official docs should go first? (And the "60 minute" thing below model zoo of which it is part?)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2209 +/- ##
==========================================
- Coverage 82.60% 79.83% -2.78%
==========================================
Files 23 24 +1
Lines 1581 1572 -9
==========================================
- Hits 1306 1255 -51
- Misses 275 317 +42 ☔ View full report in Codecov by Sentry. |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken links I found in CONTRIBUTING.md
Under the Learn Flux section: