Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc reference for gpu_backend! #2292

Closed
wants to merge 3 commits into from
Closed

doc reference for gpu_backend! #2292

wants to merge 3 commits into from

Conversation

CarloLucibello
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (d3a083c) to head (7f6e9d3).
Report is 211 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2292      +/-   ##
==========================================
+ Coverage   79.02%   79.90%   +0.88%     
==========================================
  Files          31       31              
  Lines        1721     1911     +190     
==========================================
+ Hits         1360     1527     +167     
- Misses        361      384      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcabbott
Copy link
Member

How easy would it be to make this friendlier?

julia> using Flux, Metal

julia> x = rand(Float32, 3) |> Flux.gpu
┌ Info: The CUDA functionality is being called but
│ `CUDA.jl` must be loaded to access it.
└ Add `using CUDA` or `import CUDA` to your code.

The minimal step would be to change this message, so that it mentions that you could be trying to use Metal / AMDGPU but have the wrong global setting.

If the Metal extension is loaded, it could be even more specific. Perhaps ideally, it would prompt you the way using Flux does, "do you want to change Flux's global setting to Metal, y/n?".

@darsnack
Copy link
Member

Related to #2293 as well

@CarloLucibello
Copy link
Member Author

obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants