Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally dependency on Makie #11

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Conditionally dependency on Makie #11

merged 2 commits into from
Jun 27, 2020

Conversation

avik-pal
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 27, 2020

Codecov Report

Merging #11 into master will decrease coverage by 0.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   76.04%   75.08%   -0.96%     
==========================================
  Files          16       16              
  Lines         288      289       +1     
==========================================
- Hits          219      217       -2     
- Misses         69       72       +3     
Impacted Files Coverage Δ
src/transforms/pcloud_func.jl 84.21% <ø> (ø)
src/Flux3D.jl 33.33% <100.00%> (-46.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b32f1...8c2f7dd. Read the comment docs.

@avik-pal
Copy link
Member Author

Test failure is unrelated to this PR.

@avik-pal avik-pal merged commit 50ad1cf into master Jun 27, 2020
@avik-pal avik-pal deleted the ap/dep branch June 27, 2020 20:12
@nirmal-suthar nirmal-suthar restored the ap/dep branch July 13, 2020 14:34
nirmal-suthar added a commit that referenced this pull request Jul 13, 2020
nirmal-suthar added a commit that referenced this pull request Jul 22, 2020
@avik-pal avik-pal deleted the ap/dep branch August 4, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants