Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't print nothing #118

Merged
merged 2 commits into from
Oct 24, 2019
Merged

don't print nothing #118

merged 2 commits into from
Oct 24, 2019

Conversation

oxinabox
Copy link
Member

@MikeInnes
Copy link
Member

How about changing the original code to use repr(fdef). Seems like that'd be more correct in general anyway (e.g. for strings).

@oxinabox
Copy link
Member Author

🤷‍♂ could do.
repr can be super verbose though.

@oxinabox
Copy link
Member Author

oxinabox commented Aug 4, 2019

Do you still want it changed to repr?

@MikeInnes
Copy link
Member

In what cases is repr much more verbose? It seems like it'd be fine for Exprs, if so then yeah I think best to change it.

@oxinabox
Copy link
Member Author

Yeah it is find for Exprs, so fair

@MikeInnes
Copy link
Member

👍

@MikeInnes MikeInnes merged commit 829a861 into FluxML:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxinabox @MikeInnes