Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #55, change to let expr syntax in julia v0.7 #56

Closed
wants to merge 2 commits into from
Closed

Fix #55, change to let expr syntax in julia v0.7 #56

wants to merge 2 commits into from

Conversation

jmert
Copy link

@jmert jmert commented Sep 8, 2017

This fixes #55 and makes the package tests complete again on julia master.

Also appears to fix #54.

               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.1725 (2017-09-08 14:58 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 943c8e5775 (0 days old master)
|__/                   |  x86_64-pc-linux-gnu

julia> Pkg.test("MacroTools")
INFO: Testing MacroTools
...

WARNING: deprecated syntax "parametric method syntax foo{}(x,; )::Any around /home/justin/.julia/v0.7/MacroTools/src/utils.jl:245".
Use "foo(x,; ) where {}" instead.

WARNING: deprecated syntax "parametric method syntax add{}(a, b = 2; c = 3, d = 4)::Float64 around /home/justin/.julia/v0.7/MacroTools/src/utils.jl:245".
Use "add(a, b = 2; c = 3, d = 4) where {}" instead.

WARNING: deprecated syntax "parametric method syntax fparam{T}(a::T,; )::Any around /home/justin/.julia/v0.7/MacroTools/src/utils.jl:245".
Use "fparam(a::T,; ) where T" instead.

WARNING: deprecated syntax "parametric method syntax ::Orange{}(x,; )::Any around /home/justin/.julia/v0.7/MacroTools/src/utils.jl:245".
Use "false(x,; ) where {}" instead.

WARNING: deprecated syntax "parametric method syntax fwhere{T}(a::T,; )::Any around /home/justin/.julia/v0.7/MacroTools/src/utils.jl:245".
Use "fwhere(a::T,; ) where T" instead.
INFO: MacroTools tests passed

@jmert
Copy link
Author

jmert commented Sep 12, 2017

Looks like the tests on master/nightly are now failing due to a macro issue already reported in JuliaLang/julia#23661.

@MikeInnes
Copy link
Member

Thanks a lot for the patch. Hope you don't mind me taking #57 just because it's a bit more complete.

@jmert
Copy link
Author

jmert commented Oct 4, 2017

Closed/Made obsolete by #57

@jmert jmert closed this Oct 4, 2017
@jmert jmert deleted the fixletexpr branch October 4, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in let expressions for julia v0.7/master breaks match expressions UndefVarError splitarg julia v0.7
2 participants