Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upsample_nearest #269

Merged
merged 9 commits into from
Jan 20, 2021
Merged

Add upsample_nearest #269

merged 9 commits into from
Jan 20, 2021

Conversation

mcabbott
Copy link
Member

No description provided.

Michael Abbott added 2 commits January 17, 2021 22:09
@maxfreu
Copy link
Contributor

maxfreu commented Jan 18, 2021

Hi! Does this support GPU?

@mcabbott
Copy link
Member Author

mcabbott commented Jan 18, 2021

I haven't tried it, but I can't see why it wouldn't.

Edit -- now checked, seems fine!

@maxfreu
Copy link
Contributor

maxfreu commented Jan 18, 2021

Ok, sounds promising :D

I suggest that you remove all changes regarding bilinear upsampling and move them to #266. That way we dont mix our PRs.

@mcabbott
Copy link
Member Author

mcabbott commented Jan 18, 2021

I will remove the upsample_x(::Array, ::Int) methods, I think, as there is no need for NNlib to be too strongly attached to what the last two dimensions mean. done.

If #266 is going to be done soon, perhaps it's easiest to fix up these doc changes after that. (I know it's poor style to mix things slightly, but I'm no good at juggling too many branches locally...) Reverted for now.

@maxfreu
Copy link
Contributor

maxfreu commented Jan 18, 2021

Looks neat now! :)

but I'm no good at juggling too many branches locally.

And I'm not good at merging intertwined stuff, that's why I asked 🤣

src/upsample.jl Outdated Show resolved Hide resolved
Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
test/upsample.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants