Move NNlibCUDA #314
Merged
Move NNlibCUDA #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloLucibello
approved these changes
Apr 15, 2021
|
Our tests have gotten much more fragile recently. It might have to with the new code for AD being brittle. |
DhairyaLGandhi
commented
Apr 16, 2021
| if VERSION >= v"1.6" && CUDA.functional() | ||
| if get(ENV, "NNLIB_TEST_CUDA", "false") == "true" | ||
| import Pkg | ||
| Pkg.develop(url = "https://github.com/FluxML/NNlibCUDA.jl") |
There was a problem hiding this comment.
Move to a test dep once this is tagged
|
Merging now |
|
It's a little late now, but should we classify this kind of a change as breaking in future? #322 is a demonstration of how a minor version upgrade could drop previously working functionality (NNlib + CUDA used to be enough, now NNlibCUDA is required as well). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves NNlibCUDA to its own repo (ref #300), and reinstates the ability to test outside of the CI environment. Good to unblock @maleadt with a CUDA compatible Flux release.