-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjoint of AbstractFFTs.Plan
is too general
#899
Comments
This is also related to JuliaMath/FFTW.jl#182 as the adjoint is actually not working for |
vpuri3
added a commit
to vpuri3/Zygote.jl
that referenced
this issue
Jul 5, 2023
The potentially incorrect Zygote rules for FFT (FluxML#899) can be removed now that comprehensive Chain Rules have been added in JuliaMath/AbstractFFTs.jl#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These two invocations of the adjoint macro seem a little too general given it's not true for the (unitary) DCT plan
FFTW.DCTPlan{Float64,5,false} <: AbstractFFTs.Plan{Float64}
Zygote.jl/src/lib/array.jl
Lines 729 to 741 in 956cbcf
It's probably false for some of the real-to-real plans as well.
The text was updated successfully, but these errors were encountered: