Fix ldiv / rdiv + implement pinv #223
Conversation
| end | ||
| end | ||
|
|
||
| @adjoint function /(A::AbstractMatrix, B::Union{Diagonal, AbstractTriangular}) |
There was a problem hiding this comment.
What about / for abstract matrices? Is that still covered and I'm missing it?
There was a problem hiding this comment.
Yup. / is implemented in terms of \ for abstract matrices :)
| Z = A \ B | ||
| return Z, function(Z̄) | ||
| B̄ = A' \ Z̄ | ||
| if size(A, 1) == size(A, 2) |
There was a problem hiding this comment.
Don't we also need that A is nonsingular?
There was a problem hiding this comment.
I just elected to follow the structure in base found here precisely. I think base assumes that the user will ensure that A is well-conditioned.
|
LGTM. If you need the adjoint/transpose fixes can you rebase or pick the commits from #216, so we can include the credit? |
Well that's uncanny. I hadn't realised #216 is a thing, and somehow we've managed to implement pretty much the same thing character-for-character... Have cherry-picked both commits (not done this before, so may have made a mess of it 😬) |
|
Funny, yeah they really do seem identical. Once tests pass I think this is good to go. |
Relates to #222