Fix #627

[mohamed82008]

This PR fixes Zygote loading on Julia 1.0.

[DhairyaLGandhi]

We would need this for sure

bors r+

[mohamed82008]

Let's please get a new release after this is merged.

[cossio]

Can we add a test for this? The definition before this PR:

Base.broadcasted(f, ps::Params) = broadcasted(f, ps.order)

was passing all tests, but it should be detected.

[bors]

Build succeeded:

• ci/gitlab/gitlab.com

[mohamed82008]

I am assuming tests don't run on Julia 1.0 here.

[DhairyaLGandhi]

Is that something Julia 1.3+?

[cossio]

Travis is running tests on Julia 1.3, I think.

[mohamed82008]

I think it's just that broadcasted wasn't exported from Base.Broadcast in Julia 1.0. All you have to do to get the error in the issue is call using Zygote on Julia 1.0 :)

[cossio]

Hmmm, I have Zygote 0.4.18 and I do using Zygote without error.

[cossio]

Also, broadcasted is not exported still in Julia 1.4.

[mohamed82008]

Hmmm, I have Zygote 0.4.18 and I do using Zygote without error.

On Julia 1.0?

Also, broadcasted is not exported still in Julia 1.4.

I think it is exported from Base.Broadcast to Base but not from Base.

julia> Base.broadcasted
broadcasted (generic function with 53 methods)

[cossio]

Oh you are right. I am running Julia 1.4. I misunderstood you.

[DhairyaLGandhi]

I'd quite like registering on a green tick mark, if that's alright; just waiting on CI now.