updated moment; added resolutions to fix incompat b/t moment & testcafe #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated us to the most version of moment. Performed manual tests and automated tests -- didn't notice any issues. Upgrade did produce an incompatability b/t the version of moment used by testcafe and the one specified in our package.json. This issue is referenced here on testcafe's repo, which links out to this issue on Yarn's repo. Added resolutions to our project which specify a single version for a dependency that gets used across all dependent packages.
Let me know if you see anything I missed!
Pull requests into Flux require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable (N/A) and ✅.
Submitter:
Running the Application
Documentation
NoteParser
Code Quality
Tests
Reviewer 1: Name
Reviewer 2: Name