Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated moment; added resolutions to fix incompat b/t moment & testcafe #306

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

Dtphelan1
Copy link
Collaborator

Updated us to the most version of moment. Performed manual tests and automated tests -- didn't notice any issues. Upgrade did produce an incompatability b/t the version of moment used by testcafe and the one specified in our package.json. This issue is referenced here on testcafe's repo, which links out to this issue on Yarn's repo. Added resolutions to our project which specify a single version for a dependency that gets used across all dependent packages.

Let me know if you see anything I missed!

Pull requests into Flux require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable (N/A) and ✅.

Submitter:

Running the Application

  • Manually tested in Chrome
  • Manually tested in IE

Documentation

  • This pull request describes why these changes were made
  • Recognizes any potential shortcomings/bugs in the description
  • N/A Cheat sheet is updated
  • N/A Demo script is updated
  • N/A Documentation on Wiki has been updated
  • N/A Additional technical components and libraries are documented and added to wiki as needed

NoteParser

  • N/A Note parser has been updated if structured phrases change

Code Quality

  • N/A 4-space indents - convert any tabs to spaces
  • N/AUse public class field syntax for binding functions - ex. handleChange = () => { ... };
  • N/A Code is commented

Tests

  • Existing tests passed
  • N/A Added UI tests for slim mode
  • N/A Added UI tests for full mode
  • N/A Added backend tests for fluxNotes code
  • N/A Added note parser examples to test new functionality

Reviewer 1: Name

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2: Name

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Copy link
Contributor

@gregquinn2001 gregquinn2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nicoleng12
Copy link
Contributor

Looks good. All tests pass

@nicoleng12 nicoleng12 merged commit 4f2482d into master Apr 3, 2018
@nicoleng12 nicoleng12 deleted the moment-vuln-fix branch April 3, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants