General optimizations

[Peppe289]

Optimizations

Let's move on to things related to the code:

• If we put the static function it comes out cleaner and the assembly is happy too (yes, I know that perhaps it could be the compiler that optimizes it but it's a convention);
• Why allocate stack memory when you don't need it? instead use inline and where possible also macros.

Unnecessary

• It's a great code, don't let the switch() warnings spoil the perfection...
• We are at version 3.28 of cmake... let's raise the minimum required to remove the warning.

I tested it and it seems to work fine.

Thank's for your job.
Best regards Peppe289

[FlyGoat]

Commit 1 to 3 LGTM, thanks for your work!
For commit 4 perhaps we should leave this kind of work for LTO :-)

[FlyGoat]

It reminds me that I was intended to enable -fvisibility=hidden for RyzenAdj :-)

[FlyGoat]

Seems like -fvisibility=hidden is working as intended for now.

[Peppe289]

Commit 1 to 3 LGTM, thanks for your work! For commit 4 perhaps we should leave this kind of work for LTO :-)

In cmake I didn't see options for LTO by default.

[Peppe289]

It reminds me that I was intended to enable -fvisibility=hidden for RyzenAdj :-)

yeah optimizing through the compiler is a great option.

[Peppe289]

Well, I saw that you changed the CMake. My commit about that is no longer necessary, I will remove it.

[Peppe289]

Commit dropped, and fix for conflicts. I had committed to update cmake, but it was done this morning. So it is no longer necessary.

Best regards.

[FlyGoat]

All LGTM, thanks!